Add support for user based default access#812
Open
krakan wants to merge 2 commits intowebrecorder:mainfrom
Open
Add support for user based default access#812krakan wants to merge 2 commits intowebrecorder:mainfrom
krakan wants to merge 2 commits intowebrecorder:mainfrom
Conversation
Member
|
This is a neat solution for default rules by user, the system wasn't really designed for that as is. It may be clearer to disallow empty URLs, but instead support a list of default rules by user: and then just check from this list instead? |
Contributor
Author
|
Agreed, that is indeed clearer - I'll look into changing the PR. |
Contributor
Author
|
I opted for a dict layout of the default_access entry instead of the proposed list: |
This enables us to skip youtube-dl tests in GitHub Actions by ensuring that the "CI" env var is passed to tox.
Contributor
Author
|
There! I had forgotten to add a file (again 🤦) - and I also rebased on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a different default access for a specific user didn't previously work because
the ACL must be sorted in reversed alphabetic order which means that an empty URL (ie. a default rule) must be last, and
the search for matching ACL rules stops when the top level domain of the a rule is alphabetically lower than the one searched for.
Ie. given
default_access: allowand the ACL:and searching for
http://iana.org, the last line would not be found so that theunknownuser would still beallowed.Description
Don't stop searching for rules based on top level domain
Motivation and Context
Having a way to specify a default access rule for a specific user would be useful. In our case we would give external users access to the index but not to the data. This was previously possible only if the rule with an empty URL was the only one.
Screenshots (if appropriate):
Types of changes
Checklist: